lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Cleanup of rw_copy_check_uvector and compat_rw_copy_check_uvector
On 01/30, Christopher Yeoh wrote:
>
> ssize_t compat_rw_copy_check_uvector(int type,
> const struct compat_iovec __user *uvector, unsigned long nr_segs,
> unsigned long fast_segs, struct iovec *fast_pointer,
> - struct iovec **ret_pointer, int check_access)
> + struct iovec **ret_pointer)
> {
> compat_ssize_t tot_len;
> struct iovec *iov = *ret_pointer = fast_pointer;
> @@ -586,7 +586,7 @@ ssize_t compat_rw_copy_check_uvector(int type,
> }
> if (len < 0) /* size_t not fitting in compat_ssize_t .. */
> goto out;
> - if (check_access &&
> + if (type >=0 &&

I bet checkpatch.pl will complain, this needs the space after '>' ;)

Otherwise this is nice cleanup, imho.

Christopher, this is up to Andrew but perhaps you should update
the changelog. It should explain what this patch does (overload
"int type", remove the unnecessary "check_access", etc). It should
not simply mention the previous discussion.

Oleg.



\
 
 \ /
  Last update: 2012-01-30 18:33    [from the cache]
©2003-2011 Jasper Spaans