[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/4 V10] Add ioctl for KVMCLOCK_GUEST_STOPPED
On 01/30/2012 05:32 PM, Eric B Munson wrote:
> >
> > Can you point me to the discussion that moved this to be a vm ioctl? In
> > general vm ioctls that do things for all vcpus are racy, like here.
> > You're accessing variables that are protected by the vcpu mutex, and not
> > taking the mutex (nor can you, since it is held while the guest is
> > running, unlike most kernel mutexes).
> >
> Jan Kiszka suggested that becuase there isn't a use case for notifying
> individual vcpus (can vcpu's be paused individually?

They can, though the guest will grind to a halt very soon.

> ) that it makes more sense
> to have a vm ioctl.
> If the per vcpu ioctl is the right choice I can resend those patches.

The races are solvable but I think it's easier in userspace. It's also
more flexible, though I don't really see a use for this flexibility.

error compiling committee.c: too many arguments to function

 \ /
  Last update: 2012-01-30 16:53    [W:0.050 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site