lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/6] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute
    On Mon, Jan 30, 2012 at 4:49 PM, Joerg Roedel <joerg.roedel@amd.com> wrote:
    > Hardware specific attributes are intended, but not limited to hardware
    > specific drivers. A generic driver that _may_ run on a given hardware
    > can use a hardware specific attribute too. If it doesn't run on this
    > hardware it will just get -EINVAL back.

    That sounds good.

    But I'm still not sure what's the advantage of the attribute API on
    top of regular, type-safe, dedicated API for every attribute: it
    doesn't sound like there's a vast number of attributes, only a
    handful, and dedicated API just sound (to me) much more readable and
    less prone to error.

    But, again, maybe it's only me :)

    Thanks,
    Ohad.


    \
     
     \ /
      Last update: 2012-01-30 16:45    [W:0.031 / U:34.444 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site