lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Bad SSD performance with recent kernels
On Mon, Jan 30, 2012 at 06:31:34PM +0800, Li, Shaohua wrote:

> Looks the 2.6.39 block plug introduces some latency here. deleting
> blk_start_plug/blk_finish_plug in generic_file_aio_read seems
> workaround
> the issue. The plug seems not good for sequential IO, because readahead
> code already has plug and has fine grained control.

Why not remove the generic_file_aio_read() plug completely? It
actually prevents unplugging immediately after the readahead IO is
submitted and in turn stalls the IO pipeline as showed by Eric's
blktrace data.

Eric, will you test this patch? Thank you.

--- linux.orig/mm/filemap.c 2012-01-30 22:27:11.000000000 +0800
+++ linux/mm/filemap.c 2012-01-30 22:27:25.000000000 +0800
@@ -1414,15 +1414,12 @@ generic_file_aio_read(struct kiocb *iocb
unsigned long seg = 0;
size_t count;
loff_t *ppos = &iocb->ki_pos;
- struct blk_plug plug;

count = 0;
retval = generic_segment_checks(iov, &nr_segs, &count, VERIFY_WRITE);
if (retval)
return retval;

- blk_start_plug(&plug);
-
/* coalesce the iovecs and go direct-to-BIO for O_DIRECT */
if (filp->f_flags & O_DIRECT) {
loff_t size;
@@ -1495,7 +1492,6 @@ generic_file_aio_read(struct kiocb *iocb
break;
}
out:
- blk_finish_plug(&plug);
return retval;
}
EXPORT_SYMBOL(generic_file_aio_read);

\
 
 \ /
  Last update: 2012-01-30 15:41    [W:0.053 / U:25.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site