Messages in this thread | | | Date | Mon, 30 Jan 2012 15:31:11 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH 6/6] pagemap: introduce data structure for pagemap entry |
| |
On Fri, 27 Jan 2012 18:02:53 -0500 Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
> Currently a local variable of pagemap entry in pagemap_pte_range() > is named pfn and typed with u64, but it's not correct (pfn should > be unsigned long.) > This patch introduces special type for pagemap entry and replace > code with it. > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > --- > fs/proc/task_mmu.c | 66 +++++++++++++++++++++++++++------------------------ > 1 files changed, 35 insertions(+), 31 deletions(-) > > diff --git 3.3-rc1.orig/fs/proc/task_mmu.c 3.3-rc1/fs/proc/task_mmu.c > index e2063d9..c2807a3 100644 > --- 3.3-rc1.orig/fs/proc/task_mmu.c > +++ 3.3-rc1/fs/proc/task_mmu.c > @@ -586,9 +586,13 @@ const struct file_operations proc_clear_refs_operations = { > .llseek = noop_llseek, > }; > > +typedef struct { > + u64 pme; > +} pme_t; > +
A nitpick..
How about pagemap_entry_t rather than pme_t ?
At 1st look, I wondered whether this is a new kind of page table entry type or not ..
Thanks, -Kame
| |