lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] staging: android: lowmemorykiller: Drop tasklist_lock usage
On 01/30, Anton Vorontsov wrote:
>
> @@ -132,8 +134,8 @@ static int lowmem_shrink(struct shrinker *s, struct shrink_control *sc)
> }
> selected_oom_adj = min_adj;
>
> - read_lock(&tasklist_lock);
> - for_each_process(p) {
> + for_each_tgid(ns, iter) {

This makes force_sig() below unsafe, it can race with the exiting task.

Oleg.



\
 
 \ /
  Last update: 2012-01-30 14:55    [W:0.028 / U:16.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site