lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH] tracing/module: Move tracepoint out of module.h
From
Date
On Fri, 2012-01-27 at 13:32 +1030, Rusty Russell wrote:
> On Thu, 26 Jan 2012 19:39:46 +0100, Ingo Molnar <mingo@elte.hu> wrote:
> > Ok, i like this one best. Rusty, does it look good to you too?
>
> No, the if (module) test belongs in the inline wrapper (since gcc knows
> that at compile time).

For some reason though it still adds 5K when we keep the code as a
static inline. Note, my test config does have all the necessary modules
to boot the box as compiled in (not as modules). If necessary, I could
compile with a distro config and see what the differences are with that.

Rusty, the final decision is yours. If you believe that the added code
size is worth having the static inlines, then I'll go back to the
previous version that had that.

I'll compile with a distro config, and then take a look at the
differences of the vmlinux.
Thanks,

-- Steve




\
 
 \ /
  Last update: 2012-01-30 12:55    [from the cache]
©2003-2011 Jasper Spaans