Messages in this thread | | | Date | Tue, 3 Jan 2012 12:24:24 +0000 | From | Matthew Garrett <> | Subject | Re: loading firmware while usermodehelper disabled. |
| |
On Mon, Jan 02, 2012 at 09:53:46PM -0800, Linus Torvalds wrote: > On Mon, Jan 2, 2012 at 7:25 PM, Matthew Garrett <mjg@redhat.com> wrote: > > On Mon, Jan 02, 2012 at 09:45:58PM -0500, Alan Stern wrote: > > > >> Wait a second. Why does isight_firmware bind at this time? Binding to > >> new devices is handled by khubd, which doesn't start running again > >> until after the resume is finished (the device appears to be new > >> because its descriptors have changed). At that point there should be > >> no trouble reloading the firmware. > > > > Then why are we getting this warning? The firmware is only loaded in the > > probe function. > > The USB suspend/resume function does that "unbind/rebind" dance, and > that causes a "device_attach()". Which causes a probe() to be called. > > Should it do that? I think not, not if the ID's haven't changed. But I > don't know the USB layer all that well.
The IDs will have changed due to the firmware falling out.
-- Matthew Garrett | mjg59@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |