Messages in this thread | | | Date | Tue, 3 Jan 2012 16:44:52 -0800 | From | Greg KH <> | Subject | Re: [PATCH -next] debugfs: add missing #ifdef HAS_IOMEM |
| |
On Tue, Dec 27, 2011 at 03:08:28PM +0100, Heiko Carstens wrote: > "debugfs: add tools to printk 32-bit registers" adds new functions which rely > on IOMEM functionality which is not present on all architectures and therefore > result in compile errors: > > fs/debugfs/file.c: In function 'debugfs_print_regs32': > fs/debugfs/file.c:561:7: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
Who does not have readl()? Surely there should be a .h file we are just missing to include?
> Add an #ifdef CONFIG_HAS_IOMEM to fix this
I guess this is ok, thanks for the patch.
greg k-h
| |