[lkml]   [2012]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] fs/ext4: add missing ext4_resize_end
    On Fri, Dec 23, 2011 at 09:14:20AM +0800, Yongqiang Yang wrote:
    > Thanks.
    > The patch looks good. I have to update the new resize patch too.
    > Yongqiang.
    > On Thu, Dec 22, 2011 at 11:00 PM, Djalal Harouni <> wrote:
    > > Online resize ioctls 'EXT4_IOC_GROUP_EXTEND' and 'EXT4_IOC_GROUP_ADD'
    > > call ext4_resize_begin() to check permissions and to set the
    > > EXT4_RESIZING bit lock, they do their work and they must finish with
    > > ext4_resize_end() which calls clear_bit_unlock() to unlock and to
    > > avoid -EBUSY errors for the next resize operations.
    > >
    > > This patch adds the missing ext4_resize_end() calls on error paths.
    Any news on this one ?

    If we call EXT4_IOC_GROUP_EXTEND ioctl and get_user() fails with -EFAULT
    then any new call will return -EBUSY, unless we unmount/mount the fs.

    In rare situations this can lead to a corrupt filesystem, I've experienced
    this, but I'm not sure what I did. fsck fix it.



     \ /
      Last update: 2012-01-03 11:47    [W:0.037 / U:8.968 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site