lkml.org 
[lkml]   [2012]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH v1 0/3] Tegra30 clockframework
Peter De Schrijver wrote at Monday, January 02, 2012 8:18 AM:
> This patchset introduces the tegra30 clockframework. Clocks which require
> voltage scaling are not included in this version. The implementation doesn't
> use the generic clock code yet. It's the intention to move to it, once the
> semantics are fully clarified.

I'm not particularly familiar with Tegra's clocks, but nothing really
stood out as wrong with this patch on a quick look-through. It'd be great
if someone like Colin could look this over.

A couple thoughts below. You've probably thought about some of these
already, but I just wanted to make sure:-)

* Are we following the common clock stuff so we can move over once it's
ready?

* Are Tegra20 and Tegra30 so different we can't re-use any of the code
in tegra2_clocks.c for Tegra30?

* The device names in the peripheral clock table might benefit from a
review to make sure they match tegra2_clocks.c for the drivers we've
actually upstreamed at least.

--
nvpublic



\
 
 \ /
  Last update: 2012-01-04 00:05    [W:0.091 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site