lkml.org 
[lkml]   [2012]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] netfilter: Fix br_nf_pre_routing() in conjunction with bridge-nf-call-ip(6)tables=0
    Am 03.01.2012 21:15, schrieb Bart De Schuymer:
    > The documentation is probably not explicit enough, but I would keep the
    > behavior as it is now. Setting bridge-nf-call-iptables to 0 makes
    > iptables behave as if bridge-netfilter was not enabled at compilation.
    > Anyway, your patch is almost certainly flawed since the fact that
    > skb->nf_bridge can be NULL is used as part of the logic in
    > br_netfilter.c: it indicates that bridge-nf-call-iptables was 0 when the
    > packet was first processed by bridge-netfilter and should therefore not
    > be given to iptables in any other netfilter hook.

    Thanks for the explanation!

    Wouldn't it make sense to check for bridge-nf-call-iptables in xt_physdev?
    So that the user gets warned that his iptables rule will never match...

    Thanks,
    //richard


    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-01-03 21:31    [W:0.022 / U:61.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site