lkml.org 
[lkml]   [2012]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 09/11] virtio: net: Add freeze, restore handlers to support S4
On (Sun) 01 Jan 2012 [13:47:27], Michael S. Tsirkin wrote:
> On Fri, Dec 30, 2011 at 03:08:19PM +0530, Amit Shah wrote:
> > >
> > > > + if (!try_fill_recv(vi, GFP_KERNEL))
> > > > + schedule_delayed_work(&vi->refill, 0);
> > >
> > > This needs to be switched to non reentrant wq too?
> >
> > Subsequent invocations could create problems? Note that this will be
> > the first item to be queued in the workqueue for the refill work.
> >
> > Amit
>
> See recent patches on net-next.
> We switched other calls to a non reentrant wq so I think same
> reasoning applies there.

There's a patch ordering issue; so this series should land after the
-net series is merged.

Rusty, do you want me to re-spin this patch on top of yours, or is
that something that you'll handle?

Amit


\
 
 \ /
  Last update: 2012-01-03 18:11    [W:0.055 / U:1.652 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site