[lkml]   [2012]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [alsa-devel] [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap
    > >You can skip checking 'iores', too. I also did that in the example, but
    > >a lot of people seem to miss it.
    > I can try to do that, but it seems a little bit unintuitive.
    > Perhaps it would be easier for people to remember to put in error
    > handling code when they need it if they always have to do it? If I
    > remove it, there will be one call that has no test and then another
    > call a few lines later that does.

    I see your point. I would still like to get rid of the duplicated code
    (then it can't be forgotten as well). Maybe I should have named the
    function something alike devm_check_and_request_and_ioremap()? Then I
    could have also introduced a similar function for requesting irq. Will
    think about this a bit more. Thanks for updating your patch!

    Pengutronix e.K. | Wolfram Sang |
    Industrial Linux Solutions | |
    [unhandled content-type:application/pgp-signature]
     \ /
      Last update: 2012-01-28 09:29    [W:0.020 / U:2.236 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site