lkml.org 
[lkml]   [2012]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] x86, dumpstack: removed unneeded check in dump_trace()
On Sat, Jan 28, 2012 at 01:52:46PM +0300, Dan Carpenter wrote:
> Smatch complains that we have some inconsistent NULL checking. If
> "task" were NULL then it would lead to a NULL dereference later. We
> can remove this test because earlier on in the function we have:
> if (!task)
> task = current;
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>

>
> diff --git a/arch/x86/kernel/dumpstack_64.c b/arch/x86/kernel/dumpstack_64.c
> index 6d728d9..af7785f 100644
> --- a/arch/x86/kernel/dumpstack_64.c
> +++ b/arch/x86/kernel/dumpstack_64.c
> @@ -129,7 +129,7 @@ void dump_trace(struct task_struct *task, struct pt_regs *regs,
> if (!stack) {
> if (regs)
> stack = (unsigned long *)regs->sp;
> - else if (task && task != current)
> + else if (task != current)
> stack = (unsigned long *)task->thread.sp;
> else
> stack = &dummy;


\
 
 \ /
  Last update: 2012-01-28 12:03    [W:0.585 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site