Messages in this thread | | | Date | Sat, 28 Jan 2012 23:19:45 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH v3] watchdog: Convert jz4740_wdt driver to watchdog core |
| |
On Thu, Jan 26, 2012 at 06:10:45PM +0800, Axel Lin wrote: > This patch converts jz4740_wdt driver to use watchdog core APIs. > Also use devm_* APIs to save a few error handling code. > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > Acked-by: Paul Cercueil <paul@crapouillou.net> > --- > v3: - Remove unused define for WDT_IN_USE and WDT_OK_TO_CLOSE > - Remove mem from struct jz4740_wdt_drvdata > > v2: Address all the comments by Wolfram. > - Remove unneed header file inclusion > - Drop 'heartbeat' usage in jz4740_wdt_set_heartbeat and jz4740_wdt_start > - Init wdt_dev->timeout in probe using the global 'heartbeat' > - Remove unneed pointer check for drvdata->mem
Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>
Thanks!
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |