[lkml]   [2012]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [Intel-gfx] [PATCH 1/2] drm/i915: Force explicit bpp selection for intel_dp_link_required
On Wed, Jan 25, 2012 at 08:16:25AM -0800, Keith Packard wrote:
> It is never correct to use intel_crtc->bpp in intel_dp_link_required,
> so instead pass an explicit bpp in to this function. This patch
> only supports 18bpp and 24bpp modes, which means that 10bpc modes will
> be computed incorrectly. Fixing that will require more extensive
> changes, and so must be addressed separately from this bugfix.
> intel_dp_link_required is called from intel_dp_mode_valid and
> intel_dp_mode_fixup.
> * intel_dp_mode_valid is called to list supported modes; in this case,
> the current crtc values cannot be relevant as the modes in question
> may never be selected. Thus, using intel_crtc->bpp is never right.
> * intel_dp_mode_fixup is called during mode setting, but it is run
> well before ironlake_crtc_mode_set is called to set intel_crtc->bpp,
> so using intel_crtc-bpp in this path can only ever get a stale
> value.
> Cc: Lubos Kolouch <>
> Cc: Adam Jackson <>
> Signed-off-by: Keith Packard <>

Tested-by: (Dell Latitude 6510)

Not the original reporter and might not exactly be this bug, but likely.
Daniel Vetter
Mobile: +41 (0)79 365 57 48

 \ /
  Last update: 2012-01-27 11:33    [W:0.077 / U:0.436 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site