[lkml]   [2012]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[v7 0/8] Reduce cross CPU IPI interference
We have lots of infrastructure in place to partition multi-core systems
such that we have a group of CPUs that are dedicated to specific task:
cgroups, scheduler and interrupt affinity, and cpuisol= boot parameter.
Still, kernel code will at times interrupt all CPUs in the system via IPIs
for various needs. These IPIs are useful and cannot be avoided altogether,
but in certain cases it is possible to interrupt only specific CPUs that
have useful work to do and not the entire system.

This patch set, inspired by discussions with Peter Zijlstra and Frederic
Weisbecker when testing the nohz task patch set, is a first stab at trying
to explore doing this by locating the places where such global IPI calls
are being made and turning the global IPI into an IPI for a specific group
of CPUs. The purpose of the patch set is to get feedback if this is the
right way to go for dealing with this issue and indeed, if the issue is
even worth dealing with at all. Based on the feedback from this patch set
I plan to offer further patches that address similar issue in other code

The patch creates an on_each_cpu_mask and on_each_cpu_cond infrastructure
API (the former derived from existing arch specific versions in Tile and
Arm) and uses them to turn several global IPI invocation to per CPU
group invocations.

This 7th iteration includes the following changes, all based on feedback
from Milton Miller:

- Use a static cpumask_t to track CPUs with pcps in drain_all_pages.
- Fix logic bug sending an IPI based on state of pcps in last zone only
(and re-run tests to make sure we still see the benefits).
- Use bool and smp_call_func_t for on_each_cpu_cond prototype.
- Accept a GFP flags parameters by on_each_cpu_cond for cpumask allocation.
- Disable preemption around for_each_online_cpu in on_each_cpu_cond to avoid.
racing with hotplug events.
- Use bool and smp_call_func_t for n_each_cpu_mask prototype.
- Multiple documentation and description fixes and improvements.

The patch set also available from the ipi_noise_v7 branch at

Signed-off-by: Gilad Ben-Yossef <>
CC: Christoph Lameter <>
CC: Chris Metcalf <>
CC: Peter Zijlstra <>
CC: Frederic Weisbecker <>
CC: Pekka Enberg <>
CC: Matt Mackall <>
CC: Sasha Levin <>
CC: Rik van Riel <>
CC: Andi Kleen <>
CC: Mel Gorman <>
CC: Andrew Morton <>
CC: Alexander Viro <>
CC: Avi Kivity <>
CC: Michal Nazarewicz <>
CC: Kosaki Motohiro <>
CC: Milton Miller <>

Gilad Ben-Yossef (8):
smp: introduce a generic on_each_cpu_mask function
arm: move arm over to generic on_each_cpu_mask
tile: move tile to use generic on_each_cpu_mask
smp: add func to IPI cpus based on parameter func
slub: only IPI CPUs that have per cpu obj to flush
fs: only send IPI to invalidate LRU BH when needed
mm: only IPI CPUs to drain local pages if they exist
mm: add vmstat counters for tracking PCP drains

arch/arm/kernel/smp_tlb.c | 20 ++-------
arch/tile/include/asm/smp.h | 7 ---
arch/tile/kernel/smp.c | 19 ---------
fs/buffer.c | 15 +++++++-
include/linux/smp.h | 41 +++++++++++++++++++
include/linux/vm_event_item.h | 1 +
kernel/smp.c | 87 +++++++++++++++++++++++++++++++++++++++++
mm/page_alloc.c | 36 ++++++++++++++++-
mm/slub.c | 10 ++++-
mm/vmstat.c | 2 +
10 files changed, 194 insertions(+), 44 deletions(-)

 \ /
  Last update: 2012-01-26 11:05    [W:0.147 / U:4.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site