Messages in this thread | | | From | "Kim, Milo" <> | Date | Thu, 26 Jan 2012 18:06:14 -0800 | Subject | RE: [PATCH v2] backlight: new backlight driver for LP855x devices |
| |
> -----Original Message----- > From: Andrew Morton [mailto:akpm@linux-foundation.org] > Sent: Friday, January 27, 2012 8:47 AM > To: Kim, Milo > Cc: linux-kernel@vger.kernel.org; Richard Purdie > Subject: Re: [PATCH v2] backlight: new backlight driver for LP855x > devices > > On Tue, 24 Jan 2012 22:24:02 -0800 > "Kim, Milo" <Milo.Kim@ti.com> wrote: > > > This patch supports TI LP8550/LP8551/LP8852/LP8553/LP8556 backlight > driver. > > > > ... > > I had a few little problems here. > > - For some reason my email client doesn't like MIME quoted-printable > and cannot correctly extract the plain text. It appears that > globally deleting =\n and globally replacing =3D with = fixes things. > Ho hum. I really should go see if this has been fixed, or hassle > the sylpheed developer(s). > > - The driver generates a great storm of scripts/checkpatch.pl > whitespace warnings. Things like using eight spaces instead of a > tab. These really should be fixed, so please take a look at the > checkpatch output then resend?
Thanks a lot for your notice. In my side, 2 warnings and 2 errors are found after running checkpath.pl. I'll resend the patch after fix as title : [PATCH v3].
------------------------------------------------------------------ The result of running checkpatch : lp855x.h WARNING: please, no space before tabs #28: FILE: linux/lp855x.h:28: +#define LP8550_I2C_CONFIG ^I((ENABLE_BL << BL_CTL_SHFT) | \$
WARNING: please, no space before tabs #46: FILE: linux/lp855x.h:46: +#define LP8556_I2C_CONFIG ^I((ENABLE_BL << BL_CTL_SHFT) | \$
total: 0 errors, 2 warnings, 133 lines checked
The result of running checkpatch : lp855x_bl.c ERROR: return is not a function, parentheses are not required #134: FILE: video/backlight/lp855x_bl.c:134: + return (bl->props.brightness);
ERROR: return is not a function, parentheses are not required #156: FILE: video/backlight/lp855x_bl.c:156: + return (bl->props.brightness);
total: 2 errors, 0 warnings, 331 lines checked ------------------------------------------------------------------
But for the whitespace problem, I'm afraid something wrong in my mail client - outlook 2007. Patch mail sent from myself has normal tab indentation with plain text. But in notice mail from akpm, all tabs were replaced with 8 spaces !
Thanks & BR Milo -
| |