lkml.org 
[lkml]   [2012]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] netns: fix net_alloc_generic()
    Date
    David Miller <davem@davemloft.net> writes:

    > From: ebiederm@xmission.com (Eric W. Biederman)
    > Date: Thu, 26 Jan 2012 14:57:02 -0800
    >
    >> It is not a chicken and egg problem. It is a bug in caif.
    >> caif is claiming to be a network device when it is acting as a subsytem.
    >> That means it is being initialized too late.
    >>
    >> Untested but this should trivially fix the problem, and a bunch
    >> of others of the same ilk.
    >>
    >> It is not safe to shutdown subsystems until all of the devices
    >> are gone, otherwise there will be problems with packets in flight.
    >
    > If you guys can agree that this is the better fix, and we can
    > get testing showing that it works, I'll revert Eric D.'s patch
    > and apply the final version of this one.

    Eric D.'s change is correct, but it is just an optimization of
    net_assign_generic. Eric D.'s change is not a bug fix.

    Tested fix in a moment.

    Eric


    \
     
     \ /
      Last update: 2012-01-27 00:57    [W:3.604 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site