Messages in this thread |  | | Date | Thu, 26 Jan 2012 23:30:37 +0100 | From | Jan Kara <> | Subject | Ioctl warning for a partition |
| |
Hello,
with your patches (commit 0bfc96cb in particular) to limit ioctl on partitions we get warning: dd: sending ioctl 80306d02 to a partition! because dd checks whether given device is a tape (it's MTIOCGET ioctl). It's easy enough to silence the warning the same way as CDROM_GET_CAPABILITY since the ioctl is safe but it's not so simple for 32-bit userspace. MTIOCGET32 is defined only in fs/compat_ioctl.c so we cannot easily add it to scsi_verify_blk_ioctl(). Any opinion how to cleanly solve this? The only idea I had was to define compat structures and ioctl numbers in a special header and use it both in fs/compat_ioctl.c and in block/scsi_ioctl.c.
Honza -- Jan Kara <jack@suse.cz> SUSE Labs, CR
|  |