lkml.org 
[lkml]   [2012]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch v4, kernel version 3.2.1] Source mode for macvlan interface
From
From: Štefan Gula <steweg@ynet.sk>
Date: Thu, 26 Jan 2012 12:04:50 +0100

> 2012/1/26 David Miller <davem@davemloft.net>:
>> From: Stefan Gula <steweg@ynet.sk>
>> Date: Wed, 25 Jan 2012 09:48:54 +0100 (CET)
>>
>>> +             if (vlan->mode == MACVLAN_MODE_SOURCE &&
>>> +                     vlan->mode != nla_get_u32(data[IFLA_MACVLAN_MODE]))
>>  ...
>>> +     if (data && data[IFLA_MACVLAN_MACADDR_MODE] &&
>>> +             data[IFLA_MACVLAN_MACADDR]) {
>>  ...
>>> +                             return macvlan_hash_add_sources(vlan,
>>> +                                     nla_data(data[IFLA_MACVLAN_MACADDR]));
>>  ...
>>> +                     hlist_for_each_entry_rcu(list, n,
>>> +                             &vlan->port->vlan_source_hash[i], hlist) {
>>  ...
>>> +                     hlist_for_each_entry_rcu(list, n,
>>> +                             &vlan->port->vlan_source_hash[i], hlist) {
>>
>> Line things up on subsequent lines to the column right after the
>> openning parenthesis on the previous line.
>>
>> If things are indented too deeply, you need to write helper functions.
> Just to be sure, how many "\t" symbols are ok in patches? I want to
> avoid similar thing in future.

Keep it not to far past 80 columns.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-01-26 19:35    [W:0.170 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site