lkml.org 
[lkml]   [2012]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/4] pinctrl: Add checks for empty names in pinmux_search_function
From
On Wed, Jan 25, 2012 at 11:08 PM, Tony Lindgren <tony@atomide.com> wrote:

> This is needed as otherwise we can get the following when dealing
> with buggy data in a pinmux driver for pinmux_search_function:
>
> Unable to handle kernel NULL pointer dereference at virtual address 00000000
> ...
> PC is at strcmp+0xc/0x34
> LR is at pinmux_get+0x350/0x8f4
> ...
>
> As we need pctldev initialized to call ops->list_functions, let's
> initialize it before check_ops calls and pass the pctldev to the
> check_ops functions. Do this for both pinmux and pinconf check_ops
> functions.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

This looks correct to me, so applied it and pushed to -next
for testing.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2012-01-26 14:17    [W:0.082 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site