lkml.org 
[lkml]   [2012]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2] gpio/stmpe: support no-irq mode
    From
    On Wed, Jan 25, 2012 at 11:35 AM, Viresh Kumar <viresh.kumar@st.com> wrote:
    > On 1/25/2012 3:23 PM, Linus WALLEIJ wrote:
    >> +     if (!stmpe->pdata->no_irq) {
    >> +             irq = platform_get_irq(pdev, 0);
    >> +             if (irq < 0)
    >> +                     return irq;
    >> +     }
    >
    > I already acked it once, but there is another idea that i have :)
    > Why not allow passing no irqs in resource fields directly.
    >
    > i.e. platform_get_irq() < 0 will automatically mean irqs are not supported
    > on platform and then we can do what we are doing in your patch. This will
    > remove need of another pdata field. :)

    Hm sounds intuitively elegant! Chris, do you want to have a go
    at it?

    Yours,
    Linus Walleij
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-01-26 07:37    [W:0.021 / U:0.092 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site