lkml.org 
[lkml]   [2012]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] regulator: add device tree support for max8997
On Wed, Jan 25, 2012 at 10:55:49AM +0100, Karol Lewandowski wrote:
> On 12.01.2012 08:35, Thomas Abraham wrote:
> >Add device tree based discovery support for max8997.
>
> >+ pdata->regulators = rdata;
> >+ for_each_child_of_node(regulators_np, reg_np) {
> >+ for (i = 0; i< ARRAY_SIZE(regulators); i++)
> >+ if (!of_node_cmp(reg_np->name, regulators[i].name))
> >+ break;
> >+ rdata->id = i;
> >+ rdata->initdata = of_get_regulator_init_data(
> >+ iodev->dev, reg_np);

> One more thing - of_get_regulator_init_data() will set apply_uV to 1
> so we need to reset it for BUCK6, which doesn't provide
> set_voltage() ops, like:

> if (rdata->initdata && regulators[i].id == MAX8997_BUCK6)
> rdata->initdata->constraints.apply_uV = 0;

So, over in the other thready you were referring to mailing list posts
you made in the past few moments as examples of past issues. Please at
least mention that there hasn't been any actual discussion when doing
this...

I don't see a problem here, if the device can't set the voltage then
setting constraints to allow the voltage to be changed is silly and the
user just shouldn't do that.


\
 
 \ /
  Last update: 2012-01-25 12:29    [W:0.084 / U:4.268 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site