Messages in this thread | | | Date | Wed, 25 Jan 2012 16:05:37 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v2] gpio/stmpe: support no-irq mode |
| |
On 1/25/2012 3:23 PM, Linus WALLEIJ wrote: > + if (!stmpe->pdata->no_irq) { > + irq = platform_get_irq(pdev, 0); > + if (irq < 0) > + return irq; > + }
I already acked it once, but there is another idea that i have :) Why not allow passing no irqs in resource fields directly.
i.e. platform_get_irq() < 0 will automatically mean irqs are not supported on platform and then we can do what we are doing in your patch. This will remove need of another pdata field. :)
-- viresh
| |