lkml.org 
[lkml]   [2012]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] gpio/stmpe: support no-irq mode
On 1/25/2012 3:23 PM, Linus WALLEIJ wrote:
> + if (!stmpe->pdata->no_irq) {
> + irq = platform_get_irq(pdev, 0);
> + if (irq < 0)
> + return irq;
> + }

I already acked it once, but there is another idea that i have :)
Why not allow passing no irqs in resource fields directly.

i.e. platform_get_irq() < 0 will automatically mean irqs are not supported
on platform and then we can do what we are doing in your patch. This will
remove need of another pdata field. :)

--
viresh


\
 
 \ /
  Last update: 2012-01-25 11:37    [W:0.035 / U:3.332 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site