lkml.org 
[lkml]   [2012]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] serial/efm32: add new driver
On Wed, Jan 25, 2012 at 12:25:59AM -0800, Joe Perches wrote:
> On Wed, 2012-01-25 at 09:05 +0100, Uwe Kleine-König wrote:
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> trivial comments below:
>
> > diff --git a/drivers/tty/serial/efm32-uart.c b/drivers/tty/serial/efm32-uart.c
> []
> > @@ -0,0 +1,830 @@
> > +#if defined(CONFIG_SERIAL_EFM32_UART_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
> > +#define SUPPORT_SYSRQ
> > +#endif
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> > +static void efm32_uart_rx_chars(struct efm32_uart_port *efm_port,
> > + struct tty_struct *tty)
> > +{
> []
> > + if ((rxdata & UARTn_RXDATAX_FERR) &&
> > + !(rxdata & UARTn_RXDATAX_RXDATA__MASK)) {
>
> Perhaps better as:
>
> if ((rxdata & UARTn_RXDATAX_FERR) &&
> !(rxdata & UARTn_RXDATAX_RXDATA__MASK)) {
This is how my editor does the indention. I'm sure this can be changed,
but I want the indention only to depend on the logical structure not on
where the opening parenthesis in the previous line is. This saves
context changes for future patches.

> and RXDATA__MASK with 2 underscores? perhaps just one _?
Yeah, I like seperating the register bit field name from that fact that
the #define holds a mask.

> > +static int efm32_uart_console_setup(struct console *co, char *options)
> []
> > + for (i = 0; i < ARRAY_SIZE(efm32_uart_ports); ++i) {
> > + if (efm32_uart_ports[i]) {
> > + pr_warn("efm32-console: fall back to console index %u (from %hhi)\n",
> > + i, co->index);
>
> pr_warn("fall back to ..."
> []
> > + efm_port = efm32_uart_ports[co->index];
> > + if (!efm_port) {
> > + pr_warn("efm32-console: No port at %d\n", co->index);
>
> pr_warn("No port at..."
I intentionally did that, as these two messages are related to the
console part of the serial driver while the rest of the messages are
about the serial/tty stuff. And I didn't like changing the definition of
pr_fmt in the middle of the file.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-01-25 09:43    [W:0.051 / U:0.120 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site