[lkml]   [2012]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v9 3.2 2/9] uprobes: handle breakpoint and signal step exception.
> >>
> >> One question that could be asked is why arent we using instruction_pointer
> >> instead of GET_IP since instruction_pointer is being defined in 25
> >> places and with references in 120 places.
> >
> > i think you misunderstand the point.  {G,S}ET_IP() is the glue between the
> > arch's pt_regs struct and the public facing API.  the only people who should
> > be touching those macros are the ptrace core.  instruction_pointer() and
> > instruction_pointer_set() are the API that asm/ptrace.h exports to the rest of
> > the tree.
> Srikar: does that make sense ? i'm happy to help with improving
> asm-generic/ptrace.h.
> -mike

Yes, I think it makes sense. I have modified the code to use
instruction_pointer_set instead of set_instruction_pointer.

Thanks and Regards

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2012-01-25 09:25    [W:0.120 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site