Messages in this thread | | | Date | Wed, 25 Jan 2012 13:42:23 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH v9 3.2 2/9] uprobes: handle breakpoint and signal step exception. |
| |
> >> > >> One question that could be asked is why arent we using instruction_pointer > >> instead of GET_IP since instruction_pointer is being defined in 25 > >> places and with references in 120 places. > > > > i think you misunderstand the point. {G,S}ET_IP() is the glue between the > > arch's pt_regs struct and the public facing API. the only people who should > > be touching those macros are the ptrace core. instruction_pointer() and > > instruction_pointer_set() are the API that asm/ptrace.h exports to the rest of > > the tree. > > Srikar: does that make sense ? i'm happy to help with improving > asm-generic/ptrace.h. > -mike >
Yes, I think it makes sense. I have modified the code to use instruction_pointer_set instead of set_instruction_pointer.
-- Thanks and Regards Srikar
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |