lkml.org 
[lkml]   [2012]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Compat 32-bit syscall entry from 64-bit task!?
From
On Thu, January 26, 2012 00:32, Denys Vlasenko wrote:
> On Wednesday 25 January 2012 20:36, Oleg Nesterov wrote:
>> On 01/18, Linus Torvalds wrote:
>> >
>> > Using the high bits of 'eflags' might work.
>>
>> I thought about changing eflags too, this looks very natural to me.
>>
>> But I do not understand the result of this discussion, are you going
>> to apply this change?
>>
>> If not...
>>
>> Not sure this is really better, but there is another idea. Currently we
>> have PTRACE_O_TRACESYSGOOD to avoid the confusion with the real SIGTRAP.
>> Perhaps we can add PTRACE_O_TRACESYS_VERY_GOOD (or we can look at
>> PT_SEIZED instead) and report TS_COMPAT via ptrace_report_syscall ?

Disadvantage of that is that all archs have to add support for this,
while it only affects x86_64.

>>
>> IOW. Currently ptrace_report_syscall() does
>>
>> ptrace_notify(SIGTRAP | ((ptrace & PT_TRACESYSGOOD) ? 0x80 : 0));
>>
>> We can add the new events,
>>
>> PTRACE_EVENT_SYSCALL_ENTRY
>> PTRACE_EVENT_SYSCALL_COMPAT_ENTRY
>> PTRACE_EVENT_SYSCALL_EXIT
>> PTRACE_EVENT_SYSCALL_COMPAT_EXIT
>
> We can get away with just the first one.
> (1) It's unlikely people would want to get native sysentry events but not compat ones,
> thus first two options can be combined into one;

True.

> (2) syscall exit compat-ness is known from entry type - no need to indicate it; and
> (3) if we would flag syscall entry with an event value in wait status, then syscall
> exit will be already distinquisable.

False for execve which messes everything up by changing TID sometimes.

>
> Thus, minimally we need one new option, PTRACE_O_TRACE_SYSENTRY -
> "on syscall entry ptrace stop, set a nonzero event value in wait status"
> , and two event values: PTRACE_EVENT_SYSCALL_ENTRY (for native entry),
> PTRACE_EVENT_SYSCALL_ENTRY1 for compat one.

Not all code wants to receive a syscall exit event all the time, so
if you add PTRACE_O_TRACE_SYSENTRY, please add PTRACE_O_TRACE_SYSEXIT
too. That would pretty much halve ptrace's overhead for my use case.
But this is orthogonal to the compat problem.

> To future-proof this scheme we may reserve a few more event values
> PTRACE_EVENT_SYSCALL_ENTRY2, PTRACE_EVENT_SYSCALL_ENTRY3, etc,
> if we'll ever have arches with more than one non-native syscall
> entry. I'm no expert, but looking at strace code, ARM may already have
> more than one additional convention how to pass syscall args.

Please, no! This way lays madness, just one PTRACE_EVENT_SYSCALL_ENTRY,
no PTRACE_EVENT_SYSCALL_ENTRY1 or PTRACE_EVENT_SYSCALL_ENTRY2, that
would be horrible. Keep arch specific stuff in arch specific areas,
please don't spread it around.

What was wrong with using eflags again? Is it too simple or something?

Greetings,

Indan




\
 
 \ /
  Last update: 2012-01-26 01:43    [from the cache]
©2003-2011 Jasper Spaans