Messages in this thread | | | Date | Wed, 25 Jan 2012 16:20:35 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 3/3] mm: adjust rss counters for migration entiries |
| |
On Wed, 25 Jan 2012 15:01:38 -0800 (PST) Hugh Dickins <hughd@google.com> wrote:
> > > > : From: Konstantin Khlebnikov<khlebnikov@openvz.org> > > > > : Subject: mm: postpone migrated page mapping reset > > > > : > > > > : Postpone resetting page->mapping until the final > > > > remove_migration_ptes(). > > > > : Otherwise the expression PageAnon(migration_entry_to_page(entry)) does > > > > not > > > > : work. > > > > : > > > > : Signed-off-by: Konstantin Khlebnikov<khlebnikov@openvz.org> > > > > : Cc: Hugh Dickins<hughd@google.com> > > > > : Cc: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com> > > > > > > Isn't this one actually an essential part of the fix? It should have > > > been part of the same patch, but you split them apart, now Andrew has > > > reordered them and pushed one part to 3.3, but this needs to go in too? > > > > > > > Oops. I missed that. Yes. race-fix does not work for anon-memory without that > > patch. > > But this is non-fatal, there are no new bugs. > > Non-fatal and no new bug, yes, but it makes the fix which has already > gone in rather less of a fix than was intended (it'll get the total right, > but misreport anon as file). Andrew, please add this one to your next > push to Linus - thanks.
Shall do.
| |