lkml.org 
[lkml]   [2012]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/4] fs, proc: Introduce /proc/<pid>/task/<tid>/children entry v8
On Tue, Jan 24, 2012 at 03:53:03PM -0800, Andrew Morton wrote:
> On Mon, 23 Jan 2012 18:20:37 +0400
> Cyrill Gorcunov <gorcunov@openvz.org> wrote:
>
> > When we do checkpoint of a task we need to know the list of children
> > the task, has but there is no easy and fast way to generate reverse
> > parent->children chain from arbitrary <pid> (while a parent pid is
> > provided in "PPid" field of /proc/<pid>/status).
> >
> > So instead of walking over all pids in the system (creating one big process
> > tree in memory, just to figure out which children a task has) -- we add
> > explicit /proc/<pid>/task/<tid>/children entry, because the kernel already has
> > this kind of information but it is not yet exported.
> >
> > This is a first level children, not the whole process tree.
>
> Is there a reason for not putting this new code inside
> CONFIG_CHECKPOINT_RESTART? If so, please changelog that.
>

I don't know if someone might need it as well, so I've asked in one of
previous iterations if this file is to be under CONFIG_CHECKPOINT_RESTART.
So, sure, I'll wrap it this way.

> We could add
>
> /* #ifdef CONFIG_CHECKPOINT_RESTART (reasoning goes here) */
>
> so that if we should decide to pull all this code out again, a grep
> will flag this code for consideration.
>

Cyrill


\
 
 \ /
  Last update: 2012-01-25 07:55    [W:0.114 / U:2.920 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site