lkml.org 
[lkml]   [2012]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v9 3.2 1/9] uprobes: Install and remove breakpoints.
On Wed, Jan 25, 2012 at 4:13 PM, Denys Vlasenko
<vda.linux@googlemail.com> wrote:
>> +       /*
>> +        * Convert from rip-relative addressing to indirect addressing
>> +        * via a scratch register.  Change the r/m field from 0x5 (%rip)
>> +        * to 0x0 (%rax) or 0x1 (%rcx), and squeeze out the offset field.
>> +        */
>> +       reg = MODRM_REG(insn);
>> +       if (reg == 0) {
>> +               /*
>> +                * The register operand (if any) is either the A register
>> +                * (%rax, %eax, etc.) or (if the 0x4 bit is set in the
>> +                * REX prefix) %r8.  In any case, we know the C register
>> +                * is NOT the register operand, so we use %rcx (register
>> +                * #1) for the scratch register.
>> +                */
>> +               uprobe->arch_info.fixups = UPROBES_FIX_RIP_CX;
>> +               /* Change modrm from 00 000 101 to 00 000 001. */
>> +               *cursor = 0x1;

Hmm. I think we have a bug here.

What if this instruction has REX.B = 1? Granted, REX.B = 1 has no effect on
rip-relative addressing and therefore normally won't be generated by gcc/as,
but still. If you replace md and r/m fields as above, you are trying to convert
0x12345678(%rip) reference to (%rcx), but if REX.B = 1, then you in fact
converted it to (%r9)!

--
vda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-01-25 16:35    [W:0.119 / U:0.308 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site