Messages in this thread Patch in this message | | | From | "Kim, Milo" <> | Date | Tue, 24 Jan 2012 17:51:04 -0800 | Subject | [PATCH v2 1/2] leds-lm3530: set the value of max_brightness to 127 |
| |
Only 7 bits are used for the brightness. (register address : A0h) So the max_brightness property of lm3530 should be set to 127.
On initializing registers, maximum initial brightness is limited to 'max_brightness'.
Division-by-two is removed on updating the value of brightness. This arithmetic is not necessary because the range of brightness is 0 ~ 127.
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com> --- drivers/leds/leds-lm3530.c | 22 +++++++++++----------- 1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/leds/leds-lm3530.c b/drivers/leds/leds-lm3530.c index a7f24f7..7005a5f 100644 --- a/drivers/leds/leds-lm3530.c +++ b/drivers/leds/leds-lm3530.c @@ -153,11 +153,11 @@ static int lm3530_init_registers(struct lm3530_data *drvdata) u8 als_imp_sel = 0; u8 brightness; u8 reg_val[LM3530_REG_MAX]; - struct lm3530_platform_data *pdata = drvdata->pdata; + struct lm3530_platform_data *pltfm = drvdata->pdata; struct i2c_client *client = drvdata->client; - gen_config = (pdata->brt_ramp_law << LM3530_RAMP_LAW_SHIFT) | - ((pdata->max_current & 7) << LM3530_MAX_CURR_SHIFT); + gen_config = (pltfm->brt_ramp_law << LM3530_RAMP_LAW_SHIFT) | + ((pltfm->max_current & 7) << LM3530_MAX_CURR_SHIFT); if (drvdata->mode == LM3530_BL_MODE_MANUAL || drvdata->mode == LM3530_BL_MODE_ALS) @@ -165,27 +165,27 @@ static int lm3530_init_registers(struct lm3530_data *drvdata) if (drvdata->mode == LM3530_BL_MODE_ALS) { als_config = - (pdata->als_avrg_time << LM3530_ALS_AVG_TIME_SHIFT) | + (pltfm->als_avrg_time << LM3530_ALS_AVG_TIME_SHIFT) | (LM3530_ENABLE_ALS) | - (pdata->als_input_mode << LM3530_ALS_SEL_SHIFT); + (pltfm->als_input_mode << LM3530_ALS_SEL_SHIFT); als_imp_sel = - (pdata->als1_resistor_sel << LM3530_ALS1_IMP_SHIFT) | - (pdata->als2_resistor_sel << LM3530_ALS2_IMP_SHIFT); + (pltfm->als1_resistor_sel << LM3530_ALS1_IMP_SHIFT) | + (pltfm->als2_resistor_sel << LM3530_ALS2_IMP_SHIFT); } if (drvdata->mode == LM3530_BL_MODE_PWM) gen_config |= (LM3530_ENABLE_PWM) | - (pdata->pwm_pol_hi << LM3530_PWM_POL_SHIFT) | + (pltfm->pwm_pol_hi << LM3530_PWM_POL_SHIFT) | (LM3530_ENABLE_PWM_SIMPLE); - brt_ramp = (pdata->brt_ramp_fall << LM3530_BRT_RAMP_FALL_SHIFT) | - (pdata->brt_ramp_rise << LM3530_BRT_RAMP_RISE_SHIFT); + brt_ramp = (pltfm->brt_ramp_fall << LM3530_BRT_RAMP_FALL_SHIFT) | + (pltfm->brt_ramp_rise << LM3530_BRT_RAMP_RISE_SHIFT); if (drvdata->brightness) brightness = drvdata->brightness; else - brightness = drvdata->brightness = pdata->brt_val; + brightness = drvdata->brightness = pltfm->brt_val; if (brightness > drvdata->led_dev.max_brightness) brightness = drvdata->led_dev.max_brightness; -- 1.7.4.1
Best Regards, Milo (Woogyom) Kim Texas Instruments Incorporated
| |