Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 24 Jan 2012 12:20:46 -0800 | Subject | Re: [PATCH] hpwdt: clean up set_memory_x call for 32 bit |
| |
So I don't know who is supposed to be handling this (Wim?), but the patch itself looks suspicious.
On Sun, Jan 15, 2012 at 8:02 PM, Maxim Uvarov <maxim.uvarov@oracle.com> wrote: > - set_memory_x((unsigned long)bios32_entrypoint, (2 * PAGE_SIZE)); > + set_memory_x((unsigned long)bios32_entrypoint & PAGE_MASK, 2);
If it wasn't page-aligned to begin with, then maybe it needs three pages now?
> - set_memory_x((unsigned long)cru_rom_addr, cru_length); > + set_memory_x((unsigned long)cru_rom_addr & PAGE_MASK, cru_length >> PAGE_SHIFT);
Same here. If we align the start address down, we should fix up the length. And should we not align the number of pages up?
In general, a "start/length" conversion to a "page/nr" model needs to be roughly
len += start & ~PAGE_MASK; start &= PAGE_MASK; nr_pages = (len + PAGE_SIZE - 1) >> PAGE_SHIFT;
to do things right. But I don't know where those magic numbers come from. Maybe the "2" is already due to the code possibly traversing a page boundary, and has already been fixed up. Somebody who knows the driver and the requirements should take a look at this.
Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |