Messages in this thread | | | Date | Tue, 24 Jan 2012 08:34:31 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH 14/16] blkcg: don't allow or retain configuration of missing devices |
| |
On Tue, Jan 24, 2012 at 11:32:24AM -0500, Vivek Goyal wrote: > > Yeap, there is. Nice catch. blkg_lookup_create() should be testing > > blk_queue_bypass() instead of blk_queue_dead() and parse_and_set > > should probably retry after a bit. Will update. > > So now group creation fails if queue is in bypass mode. So a per device > rule setting will fail both for cfq and throttling logic while device > is still around. So a user is supposed to retry? How would a user know > that elevator switch is happening and he should retry and till when should > he retry.
Ummm... I'm working on the second patch which makes parse_and_set do return restart_syscall().
-- tejun
| |