lkml.org 
[lkml]   [2012]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/9] perf: Add sysfs format attribute for pmu device
From
Date
On Mon, 2012-01-23 at 16:33 +0100, Jiri Olsa wrote:
>
> > > +static ssize_t perf_default_event_format(struct pmu *pmu, char *page)
> > > +{
> > > + ssize_t ret;
> > > +
> > > + ret = sprintf(page, "config config:0-63\n");
> > > + ret += sprintf(page + ret, "config1 config1:0-63\n");
> > > + ret += sprintf(page + ret, "config2 config2:0-63\n");
> >
> > This looks like abuse of sysfs. The rule is one value per file.
> > When you start adding newlines I can't see how this format attribute can
> > be considered one value.
>
> ops, missed that rule.. I think we can carry the syntax files
> within perf, or have it builtin somehow.. or procfs? :) PeterZ?

There's plenty of exceptions to this rule though and touching procfs is
even less appreciated.


\
 
 \ /
  Last update: 2012-01-24 16:25    [W:0.090 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site