lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[001/129] mtdoops: fix the oops_page_used array size
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------
    Content-Length: 1181
    Lines: 33

    From: Roman Tereshonkov <roman.tereshonkov@nokia.com>

    commit 556f063580db2953a7e53cd46b47724246320f60 upstream.

    The array of unsigned long pointed by oops_page_used is allocated
    by vmalloc which requires the size to be in bytes.

    BITS_PER_LONG is equal to 32.
    If we want to allocate memory for 32 pages with one bit per page then
    32 / BITS_PER_LONG is equal to 1 byte that is 8 bits.
    To fix it we need to multiply the result by sizeof(unsigned long) equal to 4.

    Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>
    Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@linux.intel.com>
    Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/mtd/mtdoops.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mtd/mtdoops.c
    +++ b/drivers/mtd/mtdoops.c
    @@ -369,7 +369,7 @@ static void mtdoops_notify_add(struct mt

    /* oops_page_used is a bit field */
    cxt->oops_page_used = vmalloc(DIV_ROUND_UP(mtdoops_pages,
    - BITS_PER_LONG));
    + BITS_PER_LONG) * sizeof(unsigned long));
    if (!cxt->oops_page_used) {
    printk(KERN_ERR "mtdoops: could not allocate page array\n");
    return;



    \
     
     \ /
      Last update: 2012-01-24 04:15    [W:0.020 / U:1.152 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site