lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[105/129] [SCSI] sym53c8xx: Fix NULL pointer dereference in slave_destroy
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------
    Content-Length: 946
    Lines: 30

    From: Stratos Psomadakis <psomas@gentoo.org>

    commit cced5041ed5a2d1352186510944b0ddfbdbe4c0b upstream.

    sym53c8xx_slave_destroy unconditionally assumes that sym53c8xx_slave_alloc has
    succesesfully allocated a sym_lcb. This can lead to a NULL pointer dereference
    (exposed by commit 4e6c82b).

    Signed-off-by: Stratos Psomadakis <psomas@gentoo.org>
    Signed-off-by: James Bottomley <JBottomley@Parallels.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/scsi/sym53c8xx_2/sym_glue.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/scsi/sym53c8xx_2/sym_glue.c
    +++ b/drivers/scsi/sym53c8xx_2/sym_glue.c
    @@ -839,6 +839,10 @@ static void sym53c8xx_slave_destroy(stru
    struct sym_lcb *lp = sym_lp(tp, sdev->lun);
    unsigned long flags;

    + /* if slave_alloc returned before allocating a sym_lcb, return */
    + if (!lp)
    + return;
    +
    spin_lock_irqsave(np->s.host->host_lock, flags);

    if (lp->busy_itlq || lp->busy_itl) {



    \
     
     \ /
      Last update: 2012-01-24 03:53    [W:4.044 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site