lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[103/129] ACPICA: Put back the call to acpi_os_validate_address
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------
    Content-Length: 1608
    Lines: 52

    From: Lin Ming <ming.m.lin@intel.com>

    commit da4d8b287abe783d30e968155614531a0937d090 upstream.

    The call to acpi_os_validate_address in acpi_ds_get_region_arguments was
    removed by mistake in commit 9ad19ac(ACPICA: Split large dsopcode and
    dsload.c files).

    Put it back.

    Reported-and-bisected-by: Luca Tettamanti <kronos.it@gmail.com>
    Signed-off-by: Lin Ming <ming.m.lin@intel.com>
    Signed-off-by: Len Brown <len.brown@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/acpi/acpica/dsargs.c | 24 ++++++++++++++++++++++++
    1 file changed, 24 insertions(+)

    --- a/drivers/acpi/acpica/dsargs.c
    +++ b/drivers/acpi/acpica/dsargs.c
    @@ -387,5 +387,29 @@ acpi_status acpi_ds_get_region_arguments
    status = acpi_ds_execute_arguments(node, node->parent,
    extra_desc->extra.aml_length,
    extra_desc->extra.aml_start);
    + if (ACPI_FAILURE(status)) {
    + return_ACPI_STATUS(status);
    + }
    +
    + /* Validate the region address/length via the host OS */
    +
    + status = acpi_os_validate_address(obj_desc->region.space_id,
    + obj_desc->region.address,
    + (acpi_size) obj_desc->region.length,
    + acpi_ut_get_node_name(node));
    +
    + if (ACPI_FAILURE(status)) {
    + /*
    + * Invalid address/length. We will emit an error message and mark
    + * the region as invalid, so that it will cause an additional error if
    + * it is ever used. Then return AE_OK.
    + */
    + ACPI_EXCEPTION((AE_INFO, status,
    + "During address validation of OpRegion [%4.4s]",
    + node->name.ascii));
    + obj_desc->common.flags |= AOPOBJ_INVALID;
    + status = AE_OK;
    + }
    +
    return_ACPI_STATUS(status);
    }



    \
     
     \ /
      Last update: 2012-01-24 03:53    [W:4.206 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site