[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] Regression: Revert "Bluetooth: use buffer priority to mark URB_ISO_ASAP flag"
    This reverts commit b8aabfc92249b239c425da7e4ca85b7e4855e984.

    URB_ISO_ASAP may only be used with iso end points, but this patch was
    attempting to use it with a bulk endpoint. When DEBUG is defined in
    the USB stack, it checks for invalid flags and returns -EINVAL instead
    of actually transmitting the data.

    Signed-off-by: Keith Packard <>

    Ok, so this is a comedy of errors. The Bluetooth code is trying to use
    an iso-specific flag (URB_ISO_ASAP) on a bulk endpoint, which is
    invalid, but normally harmless. Unless the USB code is compiled for
    debugging, in which case it checks a bunch for incorrect usage and
    discards URBs which are wrong.

    As far as I'm concerned, #ifdef DEBUG code should never ever change
    the behaviour of the code, and so I'd say the USB code is even more
    broken than the bluetooth code...

    In any case, to reproduce this issue, enable CONFIG_USB_DEBUG and then
    try to use bluetooth (sdptool browse). You'll get error messages from
    the USB stack:

    usb 1-1.1.3: BOGUS urb flags, 2 --> 0

    Apply this patch and bluetooth starts working again.

    drivers/bluetooth/btusb.c | 3 ---
    1 files changed, 0 insertions(+), 3 deletions(-)

    diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
    index f00f596..b7c4f4e 100644
    --- a/drivers/bluetooth/btusb.c
    +++ b/drivers/bluetooth/btusb.c
    @@ -726,9 +726,6 @@ static int btusb_send_frame(struct sk_buff *skb)
    usb_fill_bulk_urb(urb, data->udev, pipe,
    skb->data, skb->len, btusb_tx_complete, skb);

    - if (skb->priority >= HCI_PRIO_MAX - 1)
    - urb->transfer_flags = URB_ISO_ASAP;


     \ /
      Last update: 2012-01-23 07:01    [W:0.019 / U:79.460 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site