lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [TRIVIAL] perf probe usability related fixes.
(2012/01/20 21:13), Srikar Dronamraju wrote:
> From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>
> Ingo pointed out few perf probe usability related errors during
> his review of uprobes.
>
> Since these issues are independent of uprobes, fixing them in a
> separate patch.
>
> Suggested-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thanks!

> ---
> tools/perf/util/probe-event.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index f6f5794..da38ec5 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -1825,7 +1825,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
> }
>
> ret = 0;
> - printf("Add new event%s\n", (ntevs > 1) ? "s:" : ":");
> + printf("Added new event%s\n", (ntevs > 1) ? "s:" : ":");
> for (i = 0; i < ntevs; i++) {
> tev = &tevs[i];
> if (pev->event)
> @@ -1880,7 +1880,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
>
> if (ret >= 0) {
> /* Show how to use the event. */
> - printf("\nYou can now use it on all perf tools, such as:\n\n");
> + printf("\nYou can now use it in all perf tools, such as:\n\n");
> printf("\tperf record -e %s:%s -aR sleep 1\n\n", tev->group,
> tev->event);
> }
> @@ -2063,7 +2063,7 @@ static int __del_trace_probe_event(int fd, struct str_node *ent)
> goto error;
> }
>
> - printf("Remove event: %s\n", ent->s);
> + printf("Removed event: %s\n", ent->s);
> return 0;
> error:
> pr_warning("Failed to delete event: %s\n", strerror(-ret));
>


--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com


\
 
 \ /
  Last update: 2012-01-24 01:29    [W:0.134 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site