[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[35/90] UBI: fix debugging messages
    3.0-stable review patch.  If anyone has any objections, please let me know.


    From: Artem Bityutskiy <>

    commit 72f0d453d81d35087b1d3ad7c8285628c2be6e1d upstream.

    Patch ab50ff684707031ed4bad2fdd313208ae392e5bb broke UBI debugging messages:
    before that commit when UBI debugging was enabled, users saw few useful
    debugging messages after attaching an MTD device. However, that patch turned
    'dbg_msg()' into 'pr_debug()', so to enable the debugging messages users have
    to enable them first via /sys/kernel/debug/dynamic_debug/control, which is
    very impractical.

    This commit makes 'dbg_msg()' to use 'printk()' instead of 'pr_debug()', just
    as it was before the breakage.

    Signed-off-by: Artem Bityutskiy <>
    Signed-off-by: Greg Kroah-Hartman <>

    drivers/mtd/ubi/debug.h | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/mtd/ubi/debug.h
    +++ b/drivers/mtd/ubi/debug.h
    @@ -51,7 +51,10 @@ struct ubi_mkvol_req;
    pr_debug("UBI DBG " type ": " fmt "\n", ##__VA_ARGS__)

    /* Just a debugging messages not related to any specific UBI subsystem */
    -#define dbg_msg(fmt, ...) ubi_dbg_msg("msg", fmt, ##__VA_ARGS__)
    +#define dbg_msg(fmt, ...) \
    + printk(KERN_DEBUG "UBI DBG (pid %d): %s: " fmt "\n", \
    + current->pid, __func__, ##__VA_ARGS__)
    /* General debugging messages */
    #define dbg_gen(fmt, ...) ubi_dbg_msg("gen", fmt, ##__VA_ARGS__)
    /* Messages from the eraseblock association sub-system */

     \ /
      Last update: 2012-01-24 01:05    [W:0.019 / U:0.596 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site