lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [patch 1/4] fs, proc: Introduce /proc/<pid>/task/<tid>/children entry v8
    From
    On Mon, Jan 23, 2012 at 11:33 AM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
    > On Mon, Jan 23, 2012 at 10:54:53AM -0800, Kees Cook wrote:
    >> On Mon, Jan 23, 2012 at 6:20 AM, Cyrill Gorcunov <gorcunov@openvz.org> wrote:
    >> > When we do checkpoint of a task we need to know the list of children
    >> > the task, has but there is no easy and fast way to generate reverse
    >> > parent->children chain from arbitrary <pid> (while a parent pid is
    >> > provided in "PPid" field of /proc/<pid>/status).
    >> > [...]
    >> > Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
    >> > Reviewed-by: Oleg Nesterov <oleg@redhat.com>
    >> > Cc: Andrew Morton <akpm@linux-foundation.org>
    >> > Cc: Pavel Emelyanov <xemul@parallels.com>
    >> > Cc: Serge Hallyn <serge.hallyn@canonical.com>
    >> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    >>
    >> Reviewed-by: Kees Cook <keescook@chromium.org>
    >>
    >> > +static int children_seq_show(struct seq_file *seq, void *v)
    >> > +{
    >> > +       struct inode *inode = seq->private;
    >> > +       pid_t pid;
    >> > +
    >> > +       pid = pid_nr_ns(v, inode->i_sb->s_fs_info);
    >> > +       return seq_printf(seq, " %d", pid);
    >> > +}
    >>
    >> Does this mean the file contents always starts with a space? I think
    >> I'd prefer a trailing space than a leading one. Better yet, neither.
    >> :)
    >>
    >
    > Yeah, it there children, they will be in say " 1 2 3 4\n" format.
    > To drop this space completely i'll have to add more code, which I
    > actually trying to escape. Can we live with it? ;)

    How about just:

    return seq_printf(seq, "%d ", pid);

    instead?

    -Kees

    --
    Kees Cook
    ChromeOS Security
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-01-23 21:33    [W:0.023 / U:12.440 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site