Messages in this thread | | | Subject | Re: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc_skb | From | Joe Perches <> | Date | Mon, 23 Jan 2012 11:56:01 -0800 |
| |
On Tue, 2012-01-24 at 00:49 +0530, Pradeep A. Dalvi wrote: > On Tue, Jan 24, 2012 at 12:10 AM, Joe Perches <joe@perches.com> wrote: > > On Mon, 2012-01-23 at 23:58 +0530, Pradeep A. Dalvi wrote: > >> Replaced deprecating dev_alloc_skb with netdev_alloc_skb in drivers/net/ethernet > >> - Removed extra skb->dev = dev after netdev_alloc_skb > > [] > >> diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c > > [] > >> @@ -871,13 +871,12 @@ lance_init_ring(struct net_device *dev, gfp_t gfp) > >> struct sk_buff *skb; > >> void *rx_buff; > >> > >> - skb = alloc_skb(PKT_BUF_SZ, GFP_DMA | gfp); > >> + skb = netdev_alloc_skb(dev, PKT_BUF_SZ); > > > > This change seems suspect. > Not really sure what made you suspect something in here. If you could > help me understand possibly broken scenarios, would essentially be > helpful. Thanks in advance!
Where did the GFP_DMA go?
| |