lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc_skb
From
On Tue, Jan 24, 2012 at 12:23 AM, David Miller <davem@davemloft.net> wrote:
> From: Joe Perches <joe@perches.com>
> Date: Mon, 23 Jan 2012 10:40:34 -0800
>
>> Perhaps you should break this large patch
>> into multiple separate patches.
>
> Agreed, this patch is way too large especially for what is obviously
> turning out to be a very non-trivial transformation in some cases
> and also new patch submitters should generally avoid large patches
> like this.

Acked! Will try to separate out trivial & non-trivial changes.
Although, still trivial changes would be big enough. And at the same
time, splitting changes into 118 patches might turn out to be
cumbersome for review.


\
 
 \ /
  Last update: 2012-01-23 20:15    [W:0.121 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site