lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc_skb
    From
    Date
    On Mon, 2012-01-23 at 23:58 +0530, Pradeep A. Dalvi wrote:
    > Replaced deprecating dev_alloc_skb with netdev_alloc_skb in drivers/net/ethernet
    > - Removed extra skb->dev = dev after netdev_alloc_skb
    []
    > diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c
    []
    > @@ -871,13 +871,12 @@ lance_init_ring(struct net_device *dev, gfp_t gfp)
    > struct sk_buff *skb;
    > void *rx_buff;
    >
    > - skb = alloc_skb(PKT_BUF_SZ, GFP_DMA | gfp);
    > + skb = netdev_alloc_skb(dev, PKT_BUF_SZ);

    This change seems suspect.
    I stopped reading here.

    Perhaps you should break this large patch
    into multiple separate patches.

    The trivial, obviously correct
    and the possibly broken.




    \
     
     \ /
      Last update: 2012-01-23 19:43    [W:0.024 / U:1.300 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site