lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] sysctl: control functionality of /proc/pid/mem
From
On Mon, Jan 23, 2012 at 6:41 AM, Eric W. Biederman
<ebiederm@xmission.com> wrote:
>> +#ifdef CONFIG_PROC_FS
>    ^^^^^^^^^^^^^^^^^^^^^^
>
> That ifdef is entertaining.  CONFIG_SYSCTL depends on CONFIG_PROC_FS
> so which interesting case did you imagine this ifdef would be false?
> Did you test to ensure the code is not compiled in that interesting case?

I noticed that when I added it, and decided to err on the side of more
configs if some day /proc/sys got moved out of /proc. Anyway, I can
easily remove it. v3 coming up...

-Kees

--
Kees Cook
ChromeOS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-01-23 19:15    [W:0.043 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site