lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/17] blkcg: make CONFIG_BLK_CGROUP bool
On Sat, Jan 21, 2012 at 07:25:09PM -0800, Tejun Heo wrote:
> Block cgroup core can be built as module; however, it isn't too useful
> as blk-throttle can only be built-in and cfq-iosched is usually the
> default built-in scheduler. Scheduled blkcg cleanup requires calling
> into blkcg from block core. To simplify that, disallow building blkcg
> as module by making CONFIG_BLK_CGROUP bool.
>
> If building blkcg core as module really matters, which I doubt, we can
> revisit it after blkcg API cleanup.

I think not allowing compiling blk-cgroup as module is a good thing.

>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Vivek Goyal <vgoyal@redhat.com>
> ---
> block/Kconfig.iosched | 5 +----
> block/blk-cgroup.c | 17 -----------------
> block/blk-cgroup.h | 10 ++--------
> init/Kconfig | 2 +-
> 4 files changed, 4 insertions(+), 30 deletions(-)
>
> diff --git a/block/Kconfig.iosched b/block/Kconfig.iosched
> index 3199b76..8dca96d 100644
> --- a/block/Kconfig.iosched
> +++ b/block/Kconfig.iosched
> @@ -23,8 +23,7 @@ config IOSCHED_DEADLINE
>
> config IOSCHED_CFQ
> tristate "CFQ I/O scheduler"
> - # If BLK_CGROUP is a module, CFQ has to be built as module.
> - depends on (BLK_CGROUP=m && m) || !BLK_CGROUP || BLK_CGROUP=y
> + depends on BLK_CGROUP

You don't need above dependency now. Otherwise if BLK_CGROUP=n then one
can't use CFQ. We just want cfq group scheduling to be dependent on
BLK_CGROUP.

Thanks
Vivek


\
 
 \ /
  Last update: 2012-01-23 16:03    [from the cache]
©2003-2011 Jasper Spaans