lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] kbuild: do not check for ancient modutils tools
On Mon, Jan 23, 2012 at 12:17 PM, Michal Marek <mmarek@suse.cz> wrote:
> On Fri, Jan 20, 2012 at 05:40:58PM +0100, Kay Sievers wrote:
>> On Wed, Jan 18, 2012 at 05:33, Cong Wang <amwang@redhat.com> wrote:
>> > On Tue, 2012-01-17 at 14:50 -0200, Lucas De Marchi wrote:
>> >> scripts/depmod.sh checks for the output of '-V' expecting that it has
>> >> module-init-tools in it. It's a hack to prevent users from using
>> >> modutils instead of module-init-tools, that only works with 2.4.x
>> >> kernels. This however prints an annoying warning for kmod tool, that is
>> >> currently replacing module-init-tools.
>
> You could call kmod "module-init-tools 3.13 (compatible; kmod 3)" ;)
>
> Just kidding.

I even wrote a patch to fake kmod as module-init-tools 4.0. Not worth
applying though :-)


>
>> >> Rather than putting another check for kmod's version, just remove it
>> >> since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
>> >> do, let depmod fail in that case because they should know what they are
>> >> doing.
>> >>
>> >> Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
>> >
>> > Acked-by: WANG Cong <amwang@redhat.com>
>>
>> Michal, mind picking this up? The warning it produces with kmod is
>> really misleading, and the check seems unnecessary these days.
>
> I applied it to kbuild.git#rc-fixes and will send it to Linus for 3.3.

Thanks
Lucas De Marchi


\
 
 \ /
  Last update: 2012-01-23 15:35    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog