lkml.org 
[lkml]   [2012]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] virtio: correct the memory barrier in virtqueue_kick_prepare()
Date
On Sun, 22 Jan 2012 13:47:57 +0200, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Fri, Jan 20, 2012 at 04:17:08PM +0800, Jason Wang wrote:
> > Use virtio_mb() to make sure the available index to be exposed before
> > checking the the avail event. Otherwise we may get stale value of
> > avail event in guest and never kick the host after.
> >
> > Signed-off-by: Jason Wang <jasowang@redhat.com>
>
> Good catch.
> Note: this fixes a bug introduced by ee7cd8981e15bcb365fc762afe3fc47b8242f630.

Indeed, great catch. It replaces the missing barrier, and after some
careful thought I've convinced myself that it is necessary for both the
avail index and flag cases.

> > START_USE(vq);
> > - /* Descriptors and available array need to be set before we expose the
> > - * new available array entries. */
> > - virtio_wmb(vq);
> > + /* We need expose available array entries before checking avail
>
> Nit:
> We need expose -> Need to expose
>
> > + * event. */
> > + virtio_mb(vq);

Fixed typo and applied.

Thanks,
Rusty.


\
 
 \ /
  Last update: 2012-01-23 01:01    [W:0.065 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site